Lint and fix python SDK (Py)RecordingStream upcasting issues
#8184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
teh-cmc
force-pushed
the
cmc/fix_rec_upcasting
branch
from
4decf6f to
f7888c3
Compare
teh-cmc
force-pushed
the
cmc/fix_rec_upcasting
branch
from
f7888c3 to
532c4fd
Compare
teh-cmc
force-pushed
the
cmc/fix_rec_upcasting
branch
from
9223dfd to
49eb8b3
Compare
jleibs
approved these changes
Nov 25, 2024
Comment on lines
+176
to
+182
| if ( | ||
| "recording=rec" in line | ||
| and "rr." not in line | ||
| and "recording=rec.to_native()" not in line | ||
| and "recording=recording.to_native()" not in line | ||
| ): | ||
| return "you must cast the RecordingStream first: `recording=recording.to_native()" |
There was a problem hiding this comment.
🙈 this will surely bite us at some point... but this will be fixed when we get rid of the wrapper types all together
emilk
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Fixes #8167 It is unapologetically disgusting, but at least it works... Someone can come up with a better solution later, I hope? ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8184?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8184?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8184) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. To deploy documentation changes immediately after merging this PR, add the `deploy docs` label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rr.log_file(rec=rec)results in a type error #8167It is unapologetically disgusting, but at least it works... Someone can come up with a better solution later, I hope?
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.To deploy documentation changes immediately after merging this PR, add the
deploy docslabel.